Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rakkess displays extra lines with no resource name and no permissons #156

Open
jpetazzo opened this issue Nov 9, 2021 · 9 comments
Open
Assignees

Comments

@jpetazzo
Copy link

jpetazzo commented Nov 9, 2021

Before the normal output, there is extra output with no resource name, and empty permissions.

It looks like if the normal output has N lines, then there will be N empty lines.*

Expected behavior

$ kubectl access-matrix --namespace=default 
NAME                                            LIST  CREATE  UPDATE  DELETE
bindings                                              ✔               
configmaps                                      ✔     ✔       ✔       ✔
controllerrevisions.apps                        ✔     ✔       ✔       ✔
cronjobs.batch                                  ✔     ✔       ✔       ✔
...

Actual behavior

$ kubectl access-matrix --namespace=default 
NAME                                            LIST  CREATE  UPDATE  DELETE
                                                ✖     ✖       ✖       ✖
                                                ✖     ✖       ✖       ✖
                                                ✖     ✖       ✖       ✖
                                                ✖     ✖       ✖       ✖
...
bindings                                              ✔               
configmaps                                      ✔     ✔       ✔       ✔
controllerrevisions.apps                        ✔     ✔       ✔       ✔
cronjobs.batch                                  ✔     ✔       ✔       ✔
...

Steps To Reproduce

$ kubectl version
Client Version: version.Info{Major:"1", Minor:"22", GitVersion:"v1.22.3", GitCommit:"c92036820499fedefec0f847e2054d824aea6cd1", GitTreeState:"archive", BuildDate:"2021-10-28T06:55:39Z", GoVersion:"go1.17.2", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"21", GitVersion:"v1.21.1", GitCommit:"5e58841cce77d4bc13713ad2b91fa0d961e69192", GitTreeState:"clean", BuildDate:"2021-05-21T23:01:33Z", GoVersion:"go1.16.4", Compiler:"gc", Platform:"linux/amd64"}
$ kubectl access-matrix version --full
rakkess:    v0.5.0
platform:   linux/amd64
git commit: e52bef14064d68573850f4f64f825b7be4800457
build date: 2021-07-25T09:13:28Z
go version: go1.16.6
compiler:   gc

Output above was reproduced on a "fresh" KinD cluster (just created with kind create cluster).

The full debug output is too long to be attached to this issue so I'm attaching it to this public gist:

https://gist.github.com/jpetazzo/0d39b6a92e927e4ff3fa5dfc549e91af

... I was wondering if that could be linked to my version of kubectl; but if I understand correctly rakkess doesn't rely on kubectl in any way, right?

Thanks!

@pedh
Copy link

pedh commented Nov 22, 2021

+1, same issue.

~ kubectl version
Client Version: version.Info{Major:"1", Minor:"22", GitVersion:"v1.22.3", GitCommit:"c92036820499fedefec0f847e2054d824aea6cd1", GitTreeState:"clean", BuildDate:"2021-10-27T18:41:28Z", GoVersion:"go1.16.9", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"21", GitVersion:"v1.21.1", GitCommit:"5e58841cce77d4bc13713ad2b91fa0d961e69192", GitTreeState:"clean", BuildDate:"2021-05-21T23:01:33Z", GoVersion:"go1.16.4", Compiler:"gc", Platform:"linux/amd64"}

~ kubectl access-matrix version --full
rakkess:    v0.5.0
platform:   linux/amd64
git commit: e52bef14064d68573850f4f64f825b7be4800457
build date: 2021-07-25T09:13:28Z
go version: go1.16.6
compiler:   gc

@AydinChavez
Copy link

Same happens to me on minikube.

kubectl version
Client Version: version.Info{Major:"1", Minor:"23", GitVersion:"v1.23.1", GitCommit:"86ec240af8cbd1b60bcc4c03c20da9b98005b92e", GitTreeState:"clean", BuildDate:"2021-12-16T11:33:37Z", GoVersion:"go1.17.5", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"22", GitVersion:"v1.22.3", GitCommit:"c92036820499fedefec0f847e2054d824aea6cd1", GitTreeState:"clean", BuildDate:"2021-10-27T18:35:25Z", GoVersion:"go1.16.9", Compiler:"gc", Platform:"linux/amd64"}

Dliv3 added a commit to Dliv3/rakkess that referenced this issue Jan 15, 2022
Dliv3 added a commit to Dliv3/rakkess that referenced this issue Jan 15, 2022
@wyuenho
Copy link

wyuenho commented Mar 28, 2022

Same here

@bryanasdev000
Copy link

Are there any CRDs already installed on these clusters?

@joyartoun
Copy link

Same here on OKD cluster. @bryanasdev000 we have a bunch of CRDs installed in the cluster.

corneliusweig pushed a commit that referenced this issue Nov 18, 2022
@corneliusweig
Copy link
Owner

I believe this should be fixed by #156.

@bataliero
Copy link

image

k3s cluster
rakkess 0.5.0

@JPrice904
Copy link

Same issue here

OpenShift cluster
rakkess 0.5.0

@Tortuginator
Copy link

The release on the krew index is still version 0.5.0 which contains this bug. The most current version in this repository is 0.5.1 in which the bug has been fixed.
So your only option is to recompile the plugin from source using the instructions in the readme and then exchange the binary in the ~/.krew/store/ folder with the newly compiled one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants