fix(video): Video play clip wasn't working #1353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cornerstone-3d-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
wayfarer3130
commented
Jun 26, 2024
| @@ -335,9 +335,9 @@ class VideoViewport extends Viewport implements IVideoViewport { | |||
| public async play() { | |||
| try { | |||
| if (!this.isPlaying) { | |||
| this.isPlaying = true; | |||
There was a problem hiding this comment.
The timing of these was causing the cine play stuff to fail. It had originally been done after the methods returned, but that ends up not actually fixing anything, so I have move them before so the cine works.
wayfarer3130
commented
Jun 26, 2024
| @@ -808,7 +808,7 @@ class VideoViewport extends Viewport implements IVideoViewport { | |||
| } | |||
|
|
|||
| public getSliceIndex() { | |||
| return this.getCurrentImageIdIndex(); | |||
| return this.getCurrentImageIdIndex() / this.scrollSpeed; | |||
There was a problem hiding this comment.
The slice index needs to agree with the scroll speed/number of slices.
wayfarer3130
commented
Jun 26, 2024
| @@ -1110,6 +1114,8 @@ class VideoViewport extends Viewport implements IVideoViewport { | |||
| element: this.element, | |||
| viewportId: this.id, | |||
| viewport: this, | |||
| imageIndex: this.getCurrentImageIdIndex(), | |||
There was a problem hiding this comment.
Need these for updating the scroll bar. The integer frame index needs to be used so that every frame is accessible.
wayfarer3130
commented
Jun 26, 2024
There was a problem hiding this comment.
Lots of little warning messages that were clogging things up trying to debug video playback.
sedghi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Fix the video play clip so it starts/stops the video.
As part of that, added support for some more tags on image rendered event for video so that a scrollbar can be kept up to date.
Changes & Results
Testing
Checklist
PR
semantic-release format and guidelines.
Code
[] My code has been well-documented (function documentation, inline comments,
etc.)
[] I have run the
yarn build:update-apito update the API documentation, and havecommitted the changes to this PR. (Read more here https://www.cornerstonejs.org/docs/contribute/update-api)
Public Documentation Updates
additions or removals.
Tested Environment