fix: Dynamic threshold wasn't working in the beta branch #1470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for cornerstone-3d-docs failed. Why did it fail? →
|
wayfarer3130
commented
Sep 18, 2024
| @@ -129,7 +129,7 @@ export default class VoxelManager<T> { | |||
| */ | |||
| public setAtIndex = (index, v) => { | |||
| const changed = this._set(index, v); | |||
| if (changed) { | |||
| if (changed !== false) { | |||
There was a problem hiding this comment.
The response is optional for the set method, as some set methods have no way to determine changed state - for those ones, assume it is changed always.
sedghi
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The preview wasn't showing at all for the dynamic threshold.
Changes & Results
The preview mode wasn't working, nor was the bidirectional auto-calculation for segmentations.
The changes are:
Testing
Run yarn example for
Checklist
PR
semantic-release format and guidelines.
Code
[] My code has been well-documented (function documentation, inline comments,
etc.)
[] I have run the
yarn build:update-apito update the API documentation, and havecommitted the changes to this PR. (Read more here https://www.cornerstonejs.org/docs/contribute/update-api)
Public Documentation Updates
additions or removals.
Tested Environment