Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Argument #1 ($value) must be of type Countable|array, stdClass given #171

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

dmason30
Copy link
Contributor

Caused by #170

image

It was trying to call count on a stdClass object which this fixes.

Also when showTotal with a value of false was in the request because of the way we are resolving the options the value was resolving to the string "false" and, therefore, always treating showTotal as true.

I have applied a fix for this also

@coroo coroo merged commit 49627b5 into coroo:master Nov 21, 2023
1 check passed
@coroo
Copy link
Owner

coroo commented Nov 21, 2023

Thank you for the contribution @dmason30 , I've release it at version 0.4.3 https:/coroo/nova-chartjs/releases/tag/v0.4.3

Please let me know if you encounter any problem. Again, Thank you.

@dmason30 dmason30 deleted the count-object-fix branch November 23, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants