Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: modd has been disabled because it is not maintained upstream! #119

Open
karolvargas opened this issue Oct 7, 2022 · 13 comments
Open

Comments

@karolvargas
Copy link

karolvargas commented Oct 7, 2022

Currently on an i7 with Mac OS 12.6 installed and getting this error when attempting to install modd with brew for the first time

Running brew update --auto-update...
==> Auto-updated Homebrew!
Updated 1 tap (homebrew/core).

You have 21 outdated formulae and 2 outdated casks installed.
You can upgrade them with brew upgrade
or list them with brew outdated.

Error: modd has been disabled because it is not maintained upstream!
@simjak
Copy link

simjak commented Nov 15, 2022

Use
go install github.com/cortesi/modd/cmd/modd@latest

@jesselang
Copy link
Contributor

Using go install does not work for me.

% go install github.com/cortesi/modd/cmd/modd@latest
# github.com/rjeczalik/notify
../../dev/go/pkg/mod/github.com/rjeczalik/[email protected]/watcher_fsevents.go:49:11: undefined: stream
../../dev/go/pkg/mod/github.com/rjeczalik/[email protected]/watcher_fsevents.go:200:13: undefined: newStream

@joncalhoun
Copy link
Collaborator

What version of Go are you running?

Can you try cleaning your caches, and then installing?

go clean -modcache
go clean -cache

@jesselang
Copy link
Contributor

Thanks for the suggestion, but it doesn't seem to make a difference. I'd be happy to open a separate issue if desired.

%  go version
go version go1.18 darwin/amd64

% go clean -modcache
% go clean -cache

% go install github.com/cortesi/modd/cmd/modd@latest
go: downloading github.com/cortesi/modd v0.0.0-20221227201034-99fec65d0ecf
go: downloading github.com/cortesi/termlog v0.0.0-20210222042314-a1eec763abec
go: downloading mvdan.cc/sh/v3 v3.3.0-0.dev.0.20210224101809-fb5052e7a010
go: downloading gopkg.in/alecthomas/kingpin.v2 v2.2.6
go: downloading github.com/cortesi/moddwatch v0.0.0-20210222043437-a6aaad86a36e
go: downloading github.com/alecthomas/units v0.0.0-20210208195552-ff826a37aa15
go: downloading github.com/alecthomas/template v0.0.0-20190718012654-fb15b899a751
go: downloading github.com/rjeczalik/notify v0.0.0-20181126183243-629144ba06a1
go: downloading github.com/bmatcuk/doublestar v1.3.4
go: downloading golang.org/x/sync v0.0.0-20210220032951-036812b2e83c
go: downloading golang.org/x/sys v0.0.0-20210630005230-0f9fa26af87c
go: downloading golang.org/x/term v0.0.0-20210317153231-de623e64d2a6
go: downloading golang.org/x/net v0.0.0-20210323141857-08027d57d8cf
go: downloading github.com/fatih/color v1.13.0
go: downloading golang.org/x/crypto v0.0.0-20210322153248-0c34fe9e7dc2
go: downloading github.com/mattn/go-colorable v0.1.9
go: downloading github.com/mattn/go-isatty v0.0.14
# github.com/rjeczalik/notify
dev/go/pkg/mod/github.com/rjeczalik/[email protected]/watcher_fsevents.go:49:11: undefined: stream
dev/go/pkg/mod/github.com/rjeczalik/[email protected]/watcher_fsevents.go:200:13: undefined: newStream

@jesselang
Copy link
Contributor

Ah, CGO_ENABLED must be enabled. I have it set to zero by default. This worked.

CGO_ENABLED=1 go install github.com/cortesi/modd/cmd/modd@latest

@jesselang
Copy link
Contributor

It appears the brew formulae for modd was disabled on September 14th, 2022 after being deprecated on August 27th, 2021. Homebrew/homebrew-core#84056 offers meaningful context (referencing #96) which points to the need for a release which uses Go modules. Presumably, once that new release exists, the formulae can be revived from its disabled state. I've updated dependencies in #123 in preparation for a new release. I hope this helps. Thanks!

@jesselang
Copy link
Contributor

@joncalhoun, I'd be interested in your review of my findings, and perhaps we could work together toward a resolution? Thanks much!

joncalhoun pushed a commit that referenced this issue Jan 9, 2023
go get -u .../. && go mod tidy

Was able to execute modd against the project which successfully ran the test suite, built and executed the built binary with a smoke test configuration. The idea here is to freshen dependencies before cutting a release to resolve #96, #119, and likely others.
joncalhoun pushed a commit that referenced this issue Jan 9, 2023
* Reflect that CGO must be enabled to directly install modd

Per #119.

* Update based on comments
@joncalhoun
Copy link
Collaborator

Sorry. Go ahead and start prepping things for a go modules release if you think that will help resolve the brew issue. Would be a good idea to have a go module version here anyway.

@jesselang
Copy link
Contributor

@joncalhoun, with #123 merged, I believe the next step would be to create a new release. After which, the homebrew formula could be updated to use that new release. Thoughts?

@uvulpos
Copy link

uvulpos commented May 17, 2023

✅ SOLVED: MacOS M1 cannot install app

I think I tried now every possible solution and nothing worked. Just to summaries everything: brew is disabled, the go get / go install command runs without issue but the command modd is unregistered and the MacOS Binary from the release section is not signed, so it is not executable.

Screenshot 2023-05-17 at 02 08 00

@joncalhoun
Copy link
Collaborator

joncalhoun commented May 17, 2023 via email

@uvulpos
Copy link

uvulpos commented May 21, 2023

I discovered that my golang installation does install it but does not register it as a command. At first I registered it in the bashrc config because I was told you cannot register commands on macos, but then I read you can do that by creating a link to /usr/local/bin/<command-name>so issue solved

@silverwind
Copy link

go install method works fine and that homebrew formula seems to have been some inofficial thing, so I recommend closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants