fix: Incorrect error message when periodlimit is not set on a feegran…

…t tx (#10050)

<!--
The default pull request template is for types feat, fix, or refactor.
For other templates, add one of the following parameters to the url:
- template=docs.md
- template=other.md
-->

## Description

I updated the error check for periodlimit on a feegrant tx to return that the user needs to set the period limit rather than that the number of arguments is incorrect.

Closes: #10049 

<!-- Add a description of the changes that this PR introduces and the files that
are the most critical to review. -->

---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [x] included the correct [type prefix](https:/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [x] added `!` to the type prefix if API or client breaking change
- [x] targeted the correct branch (see [PR Targeting](https:/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
- [x] provided a link to the relevant issue or specification
- [x] followed the guidelines for [building modules](https:/cosmos/cosmos-sdk/blob/master/docs/building-modules)
- [x] included the necessary unit and integration [tests](https:/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
- [x] added a changelog entry to `CHANGELOG.md`
- [x] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [x] updated the relevant documentation or specification
- [x] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https:/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)

CHANGELOG.md

@@ -112,6 +112,7 @@ Ref: https://keepachangelog.com/en/1.0.0/
 + [\#9980](https:/cosmos/cosmos-sdk/pull/9980) Returning the error when the invalid argument is passed to bank query total supply cli.
 + [\#10061](https:/cosmos/cosmos-sdk/pull/10061) Ensure that `LegacyAminoPubKey` struct correctly unmarshals from JSON
 * (server) [#10016](https:/cosmos/cosmos-sdk/issues/10016) Fix marshaling of index-events into server config file.
+* (x/feegrant) [\#10049](https:/cosmos/cosmos-sdk/issues/10049) Fixed the error message when `period` or `period-limit` flag is not set on a feegrant grant transaction.
 
 
 ### State Machine Breaking

x/feegrant/client/cli/tx.go

@@ -125,25 +125,28 @@ Examples:
  return err
  }
 
- if periodClock > 0 && periodLimit != nil {
- periodReset := getPeriodReset(periodClock)
- if exp != "" && periodReset.Sub(expiresAtTime) > 0 {
- return fmt.Errorf("period(%d) cannot reset after expiration(%v)", periodClock, exp)
- }
-
- periodic := feegrant.PeriodicAllowance{
- Basic: basic,
- Period: getPeriod(periodClock),
- PeriodReset: getPeriodReset(periodClock),
- PeriodSpendLimit: periodLimit,
- PeriodCanSpend: periodLimit,
- }
-
- grant = &periodic
-
- } else {
- return fmt.Errorf("invalid number of args %d", len(args))
+ if periodClock <= 0 {
+ return fmt.Errorf("period clock was not set")
  }
+
+ if periodLimit == nil {
+ return fmt.Errorf("period limit was not set")
+ }
+
+ periodReset := getPeriodReset(periodClock)
+ if exp != "" && periodReset.Sub(expiresAtTime) > 0 {
+ return fmt.Errorf("period (%d) cannot reset after expiration (%v)", periodClock, exp)
+ }
+
+ periodic := feegrant.PeriodicAllowance{
+ Basic: basic,
+ Period: getPeriod(periodClock),
+ PeriodReset: getPeriodReset(periodClock),
+ PeriodSpendLimit: periodLimit,
+ PeriodCanSpend: periodLimit,
+ }
+
+ grant = &periodic
  }
 
  allowedMsgs, err := cmd.Flags().GetStringSlice(FlagAllowedMsgs)