fix: upstream error on empty version (backport #13355)

CHANGELOG.md

@@ -37,6 +37,10 @@ Ref: https://keepachangelog.com/en/1.0.0/
 
 ## [Unreleased]
 
+### Bug Fixes
+
+* (store/iavl) [#15717](https:/cosmos/cosmos-sdk/pull/15717) Upstream error on empty version (this change was present on all version but v0.46).
+
 ## [v0.46.12](https:/cosmos/cosmos-sdk/releases/tag/v0.46.12) - 2022-04-04
 
 ### Features

store/iavl/store.go

@@ -111,7 +111,7 @@ func UnsafeNewStore(tree *iavl.MutableTree) *Store {
 // Any mutable operations executed will result in a panic.
 func (st *Store) GetImmutable(version int64) (*Store, error) {
  if !st.VersionExists(version) {
- return &Store{tree: &immutableTree{&iavl.ImmutableTree{}}}, nil
+ return nil, fmt.Errorf("version mismatch on immutable IAVL tree; version does not exist. Version has either been pruned, or is for a future block height")
  }
 
  iTree, err := st.tree.GetImmutable(version)

store/iavl/store_test.go

@@ -127,7 +127,7 @@ func TestGetImmutable(t *testing.T) {
  require.Nil(t, err)
 
  _, err = store.GetImmutable(cID.Version + 1)
- require.NoError(t, err)
+ require.Error(t, err)
 
  newStore, err := store.GetImmutable(cID.Version - 1)
  require.NoError(t, err)

store/rootmulti/store_test.go

@@ -88,7 +88,7 @@ func TestCacheMultiStoreWithVersion(t *testing.T) {
 
  // require no failure when given an invalid or pruned version
  _, err = ms.CacheMultiStoreWithVersion(cID.Version + 1)
- require.NoError(t, err)
+ require.Error(t, err)
 
  // require a valid version can be cache-loaded
  cms, err := ms.CacheMultiStoreWithVersion(cID.Version)
@@ -482,9 +482,9 @@ func TestMultiStore_Pruning(t *testing.T) {
  saved []int64
  }{
  {"prune nothing", 10, pruningtypes.NewPruningOptions(pruningtypes.PruningNothing), nil, []int64{1, 2, 3, 4, 5, 6, 7, 8, 9, 10}},
- {"prune everything", 10, pruningtypes.NewPruningOptions(pruningtypes.PruningEverything), []int64{1, 2, 3, 4, 5, 6, 7, 8, 9}, []int64{10}},
- {"prune some; no batch", 10, pruningtypes.NewCustomPruningOptions(2, 1), []int64{1, 2, 4, 5, 7}, []int64{3, 6, 8, 9, 10}},
- {"prune some; small batch", 10, pruningtypes.NewCustomPruningOptions(2, 3), []int64{1, 2, 4, 5}, []int64{3, 6, 7, 8, 9, 10}},
+ {"prune everything", 12, pruningtypes.NewPruningOptions(pruningtypes.PruningEverything), []int64{1, 2, 3, 4, 5, 6, 7}, []int64{8, 9, 10, 11, 12}},
+ {"prune some; no batch", 10, pruningtypes.NewCustomPruningOptions(2, 1), []int64{1, 2, 3, 4, 6, 5, 7}, []int64{8, 9, 10}},
+ {"prune some; small batch", 10, pruningtypes.NewCustomPruningOptions(2, 3), []int64{1, 2, 3, 4, 5, 6}, []int64{7, 8, 9, 10}},
  {"prune some; large batch", 10, pruningtypes.NewCustomPruningOptions(2, 11), nil, []int64{1, 2, 3, 4, 5, 6, 7, 8, 9, 10}},
  }
 
@@ -502,12 +502,12 @@ func TestMultiStore_Pruning(t *testing.T) {
 
  for _, v := range tc.saved {
  _, err := ms.CacheMultiStoreWithVersion(v)
- require.NoError(t, err, "expected error when loading height: %d", v)
+ require.NoError(t, err, "expected no error when loading height: %d", v)
  }
 
  for _, v := range tc.deleted {
  _, err := ms.CacheMultiStoreWithVersion(v)
- require.NoError(t, err, "expected error when loading height: %d", v)
+ require.Error(t, err, "expected error when loading height: %d", v)
  }
  })
  }