Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: Fix /txs/encode endpoint #4212

Merged
merged 2 commits into from
May 6, 2019
Merged

R4R: Fix /txs/encode endpoint #4212

merged 2 commits into from
May 6, 2019

Conversation

yangyanqing
Copy link
Contributor

closes: #4141
replace: 4147

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added a relevant changelog entry: sdkch add [section] [stanza] [message]
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Apr 27, 2019

Codecov Report

Merging #4212 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4212      +/-   ##
==========================================
+ Coverage   60.16%   60.17%   +0.01%     
==========================================
  Files         212      212              
  Lines       15188    15188              
==========================================
+ Hits         9138     9140       +2     
+ Misses       5421     5419       -2     
  Partials      629      629

@codecov
Copy link

codecov bot commented Apr 27, 2019

Codecov Report

Merging #4212 into master will increase coverage by 1.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4212      +/-   ##
==========================================
+ Coverage   59.12%   60.17%   +1.05%     
==========================================
  Files         217      212       -5     
  Lines       14595    15188     +593     
==========================================
+ Hits         8629     9140     +511     
- Misses       5328     5419      +91     
+ Partials      638      629       -9

@yangyanqing yangyanqing changed the title Fix /txs/encode endpoint R4R: Fix /txs/encode endpoint May 1, 2019
@alessio
Copy link
Contributor

alessio commented May 6, 2019

Please resolve the conflicts

@yangyanqing
Copy link
Contributor Author

Done ! Thanks a lot for prompt. @alessio

@alessio alessio merged commit 8bb2569 into cosmos:master May 6, 2019
@yangyanqing yangyanqing deleted the frank/4141-tx-encode-fit-cli-master branch May 6, 2019 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

txs encode restful api return wrong response
3 participants