Skip to content
This repository has been archived by the owner on Nov 30, 2021. It is now read-only.

Photon base denom unit precision #434

Closed
fedekunze opened this issue Aug 5, 2020 · 3 comments · Fixed by #476
Closed

Photon base denom unit precision #434

fedekunze opened this issue Aug 5, 2020 · 3 comments · Fixed by #476
Labels
Status: On Ice Type: Question
Milestone
v0.2.0

Comments

@fedekunze
Copy link
Contributor

Discuss Photon base denomination precision options:

  • 0 (current implementation)
  • 6: 1 photon = 1x10⁶ μphoton. Eg: 1 atom -> 1x10⁶ μatom
  • 18: 1 photon = 1x10¹⁸ aphoton (i.e atto). Eg: 1 ETH -> 1x10¹⁸ wei

Ref: SI prefixes for precision units
@fedekunze
Copy link
Contributor Author

@okwme thoughts?

@okwme
Copy link
Contributor

okwme commented Aug 25, 2020

sounds great!
this distinction would eventually make its way into the coin metadata work that bez implemented right?

@fedekunze
Copy link
Contributor Author

I think keeping the same base denomination with Ethereum makes sense so I'd personally go for option 3)

@fedekunze fedekunze added this to the v0.2.0 milestone Aug 25, 2020
@J-Thompson12 J-Thompson12 mentioned this issue Aug 27, 2020
Merged
11 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Status: On Ice Type: Question
Projects
None yet
Milestone
v0.2.0
Development

Successfully merging a pull request may close this issue.

change photon to aphoton cosmos/ethermint
2 participants
@okwme @fedekunze