Skip to content
This repository has been archived by the owner on Nov 30, 2021. It is now read-only.

pending changes #600

Merged
merged 4 commits into from
Nov 16, 2020
Merged

pending changes #600

merged 4 commits into from
Nov 16, 2020

Conversation

fedekunze
Copy link
Contributor

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@lgtm-com
Copy link

lgtm-com bot commented Nov 16, 2020

This pull request fixes 1 alert when merging 6f8fe5f into 250cd16 - view on LGTM.com

fixed alerts:

  • 1 for Useless assignment to local variable

@lgtm-com
Copy link

lgtm-com bot commented Nov 16, 2020

This pull request fixes 1 alert when merging 8ab03e1 into 250cd16 - view on LGTM.com

fixed alerts:

  • 1 for Useless assignment to local variable

@fedekunze fedekunze marked this pull request as ready for review November 16, 2020 20:16
@fedekunze fedekunze requested a review from noot as a code owner November 16, 2020 20:16
@fedekunze fedekunze merged commit 1a47621 into pending Nov 16, 2020
@fedekunze fedekunze deleted the fedekunze/pending branch November 16, 2020 20:16
@lgtm-com
Copy link

lgtm-com bot commented Nov 16, 2020

This pull request fixes 1 alert when merging 09d95f0 into 250cd16 - view on LGTM.com

fixed alerts:

  • 1 for Useless assignment to local variable

mergify bot pushed a commit that referenced this pull request Dec 15, 2020
* add PendingBlockNumber -1

* increase block times

* update bn

* get pending balance

* additional logic to check for pending state

* add multiple balance query

* pending state for getTransactionCount

* fix lint

* add getBlockTransactionCountByNumber code - commented

* cleanup test

* GetBlockTransactionCountByNumber

* cleanup

* getBlockByNumber

* GetTransactionByBlockNumberAndIndex

* conform to namespace changes

* exportable FormatBlock method

* eth_getTransactionByHash

* eth_getTransactionByBlockNumberAndIndex

* pending nonce

* set nonce for pending and check for invalid

* WIP: doCall

* add pending tx test

* cleanup + refactor

* push first tests and init pending

* pending changes (#600)

* cleanup

* updates

* more fixes

* lint

* update call and send

* comments and minor changes

* add pending tests into sep package

* fix latest case for eth_GetBlockTransactionCountByNumber

* fix repeating null transactions in queue

* remove repeated structs

* latestblock case

* revert init script back

* fix to exportable method

* automate pending tests; add make cmd

* move and comment out pending call test

* fix some golint

* fix unlock issue

* wip: linter stringer fix?

* stringer lint

* set arr instead of append

* instantiate with length

* sep if statement

* edit pendingblocknumber note

* switch statement

* fix and update tests

* move tests-pending into tests dir

* remove commented test

* revert to appending pendingtx

* Update tests/utils.go

Co-authored-by: Federico Kunze <[email protected]>

* Update tests/utils.go

Co-authored-by: Federico Kunze <[email protected]>

* Update tests/utils.go

Co-authored-by: Federico Kunze <[email protected]>

* require no err

* rename var

* check result for eth_sendTransaction

* update changelog

* update

* Update tests/utils.go

Co-authored-by: Federico Kunze <[email protected]>

* Update tests/tests-pending/rpc_pending_test.go

Co-authored-by: Federico Kunze <[email protected]>

* changelog

* remove redundant check

Co-authored-by: noot <[email protected]>
Co-authored-by: Federico Kunze <[email protected]>
Co-authored-by: Federico Kunze <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant