Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplication of convertToErrorEvents #7436

Open
4 tasks
chatton opened this issue Oct 10, 2024 · 1 comment
Open
4 tasks

Remove duplication of convertToErrorEvents #7436

chatton opened this issue Oct 10, 2024 · 1 comment

Comments

@chatton
Copy link
Contributor

chatton commented Oct 10, 2024

Summary

There is duplication of convertErrorToEvents between v1 and v2 message servers. This function should be moved somewhere and re-used instead of being duplicated.

See #7421 (comment)

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
  • Estimate provided
@chatton chatton mentioned this issue Oct 10, 2024
Merged
10 tasks
@damiannolan
Copy link
Member

could put this in internal/errors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
IBC-GO Eureka
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@damiannolan @chatton