Skip to content

Commit

Permalink
ICS4: Prefix Upgrade Keys (#807)
Browse files Browse the repository at this point in the history
* upgrade keys should prefix channel path to standardize key construction

* changelog
  • Loading branch information
AdityaSripal authored Aug 1, 2022
1 parent 41bb16c commit 93a2e7f
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,3 +47,4 @@ Ref: https://keepachangelog.com/en/1.0.0/

- [\#803](https:/cosmos/ibc/pull/803) Changed UpgradeState enums to match the opening handshake enum style.
- [\#802](https:/cosmos/ibc/pull/802) Move `ClientState` to the `provableStore` and add `ClientState` validation in `connOpenTry` and `connOpenAck`
- [\#807](https:/cosmos/ibc/pull/807) Upgrade keys will now prefix the channel path to align with the rest of ICS4 keys
8 changes: 4 additions & 4 deletions spec/core/ics-004-channel-and-packet-semantics/UPGRADES.md
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ The upgrade sequence path is a public path that stores the current sequence of t

```typescript
function channelUpgradeSequencePath(portIdentifier: Identifier, channelIdentifier: Identifier) Path {
return "channelUpgrades/ports/{portIdentifier}/channels/{channelIdentifier}/upgradeSequence"
return "channelUpgrades/upgradeSequence/ports/{portIdentifier}/channels/{channelIdentifier}"
}
```

Expand Down Expand Up @@ -129,7 +129,7 @@ The chain must store the previous channel end so that it may restore it if the u

```typescript
function channelRestorePath(portIdentifier: Identifier, channelIdentifier: Identifier): Path {
return "channelUpgrades/ports/{portIdentifier}/channels/{channelIdentifier}/restore"
return "channelUpgrades/restore/ports/{portIdentifier}/channels/{channelIdentifier}"
}
```

Expand All @@ -139,7 +139,7 @@ The upgrade error path is a public path that can signal an error of the upgrade

```typescript
function channelUpgradeErrorPath(portIdentifier: Identifier, channelIdentifier: Identifier): Path {
return "channelUpgrades/ports/{portIdentifier}/channels/{channelIdentifier}/upgradeError"
return "channelUpgrades/upgradeError/ports/{portIdentifier}/channels/{channelIdentifier}"
}
```

Expand Down Expand Up @@ -182,7 +182,7 @@ The upgrade timeout path is a public path set by the upgrade initiator to determ

```typescript
function channelUpgradeTimeoutPath(portIdentifier: Identifier, channelIdentifier: Identifier) Path {
return "channelUpgrades/ports/{portIdentifier}/channels/{channelIdentifier}/upgradeTimeout"
return "channelUpgrades/upgradeTimeout/ports/{portIdentifier}/channels/{channelIdentifier}"
}
```

Expand Down

0 comments on commit 93a2e7f

Please sign in to comment.