Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request feature for pause in build fail #38

Closed
sharefantasy opened this issue Dec 17, 2019 · 5 comments
Closed

Request feature for pause in build fail #38

sharefantasy opened this issue Dec 17, 2019 · 5 comments

Comments

@sharefantasy
Copy link

Hi, I would like to request for a feature. My development scene is this.

  • Run "make build" as building command
  • Output artifacts are not cleared before new build

So after build failed, Air runs the the previous success built artifact without noticing. I think a pause would be enough.

Could you please support this feature? thanks :)

Btw, I use air as nginx configuration reloader as well, it's awesome.

@tobias-kuendig
Copy link

This is a must have feature. Too many times the error message gets burried in my own process' output. The reloading has to stop once a build failed and then start over once it's fixed!

@cosmtrek
Copy link
Collaborator

No problem, an option will be added to meet your requirement :)

cosmtrek added a commit that referenced this issue Jan 1, 2020
@cosmtrek
Copy link
Collaborator

cosmtrek commented Jan 1, 2020

@sharefantasy @tobias-kuendig Done, could you try the latest version?

@tobias-kuendig
Copy link

Had to add stop_on_error = true to the config and now the build stops on error. Works like a charm, thank you @cosmtrek!

@cosmtrek cosmtrek closed this as completed Jan 3, 2020
@sharefantasy
Copy link
Author

Thanks! works well in my environment! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants