add language localizer #14
Conversation
There was a problem hiding this comment.
-
The Audio localizer task seems to only play a single audio file. It seems from the design that the task (what is presented during a fMRI run) should include multiple stimuli/events, with predetermined timings (maybe preset as tsv files, unless randomized on the fly). The save function should be rewritten to output the events.tsv file.
-
All the large binary files are indexed in git, the
data/language/localizer/folder should be initialized as a separate datalad dataset, which will be installed here as a submodule, and in the fMRI dataset asstimuli.
src/tasks/language.py
Outdated
| def _run(self, exp_win, ctl_win): | ||
| recording = sound.Sound(self.filepath) | ||
|
|
||
| win = visual.Window() |
There was a problem hiding this comment.
I am not sure why you create a window here. The way the script works is that a window exp_win is created at the beginning and use throughout the script (and is passed to _instruction, _run, ...) .
There was a problem hiding this comment.
Sorry I am getting super lost with the 2 audio versions - I can't tell if it's my setupt/mac or if I am simply doing something wrong. I might need to ask your help
|
Why in the text localizer, there is an |
|
I've fixed
Fixed making it clear what is "response time" and what is "fixation". We need to decide if we want to show an image for the response or not. |
Does this look OK as separate datalad dataset? https:/courtois-neuromod/langlocalizer.stimuli/tree/master |
There was a problem hiding this comment.
Thanks for the PR and sorry for the long delay.
For the listening localizers, there seems to be a mis-understanding of what is supposed to be a Task, see inline comments.
(Please remove the .DS_Store from the commits, you can also add a pattern to the .gitignore to avoid including these in the future. Thanks)
| @@ -14,3 +14,7 @@ | |||
| path = data/retinotopy | |||
| url = [email protected]:courtois-neuromod/retino.stimuli.git | |||
| datalad-id = 52140b46-63c8-45a7-a03f-2f2cab0db23f | |||
| [submodule "data/langauge/localizer"] | |||
| STIM_LIST = get_audios_alice(C_LIST) | ||
|
|
||
| TASKS = [] | ||
| for run_N in range(1, 3): |
There was a problem hiding this comment.
I'm not sure if that's you meant to implement such design.
Each item TASK is supposed to be a separate fMRI run, each waiting for a start trigger.
For now it seems that each trial is made into a separate fMRI run.
| degr_idx = degr_idx+1 | ||
| return STIM_LIST | ||
|
|
||
| TASKS = [] |
There was a problem hiding this comment.
same as for the other localizer
| _draw_instr() | ||
| yield | ||
|
|
||
| def _run(self, exp_win, ctl_win): |
There was a problem hiding this comment.
It seems like the run here should present more than one stimuli. That function is supposed to host the task logic (timing, ISI, keypresses of responses, ....)
First iteration, still needs work, but I did not want to slow things down.
Here are the notes and details, including comments on choices we might want to make.