Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/remote/cozy: Use cozy-stack-client methods #2258

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

taratatach
Copy link
Member

@taratatach taratatach commented Aug 16, 2022

Methods from cozy-client use a redux store to keep a local data cache
which creates a large memory footprint for Desktop without benefits
since we don't use that store.

These methods wrap cozy-stack-client methods which make the calls to
the remote Cozy without dealing with redux.
Using them should make Desktop a little lighter.

Please make sure the following boxes are checked:

  • PR is not too big
  • it improves UX & DX in some way
  • it includes unit tests matching the implementation changes
  • it includes scenarios matching a new behaviour or has been manually tested
  • it includes relevant documentation

  This version brings a new
  `CozyStackClient.DocumentCollection.findAll()` method which allows us
  to fetch all documents matching a given mango selector without making
  use of cozy-client's redux store as Desktop does not make use of it.
@taratatach taratatach self-assigned this Aug 16, 2022
  Methods from cozy-client use a redux store to keep a local data cache
  which creates a large memory footprint for Desktop without benefits
  since we don't use that store.

  These methods wrap cozy-stack-client methods which make the calls to
  the remote Cozy without dealing with redux.
  Using them should make Desktop a little lighter.
@taratatach taratatach force-pushed the core/use-cozy-stack-client-methods-to-query branch from 4414816 to f5a4375 Compare August 16, 2022 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant