-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove added LLVM apt PPA repo #265
Labels
bug
Something isn't working
Comments
2bndy5
added a commit
that referenced
this issue
Oct 18, 2024
resolves #265 Users that expect the PPA to be present _after_ running cpp-linter-action can set the environment variable `KEEP_DEBIAN_LLVM_PPA` to `true`, `on`, or `1`. By default, the PPA is removed.
2bndy5
added a commit
that referenced
this issue
Oct 18, 2024
resolves #265 Users that expect the PPA to be present _after_ running cpp-linter-action can set the environment variable `KEEP_DEBIAN_LLVM_PPA` to `true`, `on`, or `1`. By default, the PPA is removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your idea related to an existing feature?
version
Describe the behavior you would like
I noticed that the LLVM install script (for Debian Linux OS) cannot be used more than once in a single workflow run. This means users will have an error if
The error would look something like:
I solved this problem (in experiments) by removing the LLVM PPA repo after we install clang-tidy and clang-format from it:
Describe alternatives you have considered
I did consider adding the LLVM apt PPA repo manually. However, the install script takes care of a lot of other cross-distribution problems, namely determining which derivative/flavor of Debian is used. Using the install script still relieves some tech debt as it is well maintained by the LLVM project.
Additional context
The updated source of the LLVM install script can be examined from https://apt.llvm.org/llvm.sh.
The scenario in which cpp-linter-action might be used more than once in a single workflow depends on the project being analyzed. As an example, a user might want to examine different sources using different compilation databases. Ultimately, the cpp-linter python package is not well suited for multiple uses in a single CI event, but that is an issue (or multitude of issues) for another time.
In the case where a user's workflow might expect the LLVM apt PPA repo to still be employed (after running cpp-linter-action), it might be a good idea to have a new input option to prevent the removal of the LLVM apt PPA repo. I suspect this to be a rare use case though.
The text was updated successfully, but these errors were encountered: