Fix for issue #49 #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correct 32bit mask for probe invert. Probe Physically Open $6=0 <Alarm|WPos:0.000,0.000,0.000,0.000|FS:0,0|Pn:ZA|WCO:0.000,0.000,0.000,0.000> Probe is not triggered $6=1 <Alarm|WPos:0.000,0.000,0.000,0.000|FS:0,0|Pn:PZA|Ov:100,100,100> Probe is triggered Probe Physically Closed $6=0 <Alarm|WPos:0.000,0.000,0.000,0.000|FS:0,0|Pn:ZA|WCO:0.000,0.000,0.000,0.000> Probe is not triggered $6=1 <Alarm|WPos:0.000,0.000,0.000,0.000|FS:0,0|Pn:PZA|Ov:100,100,100> Probe is triggered
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct 32bit mask for probe invert. My setup works with $6=0, but the output below shows the code working as expected when $6=0 and $6=1
$6=0
Probe Physically Open
<Alarm|WPos:0.000,0.000,0.000,0.000|FS:0,0|Pn:ZA>
Probe is not triggered
Probe Physically Closed
<Alarm|WPos:0.000,0.000,0.000,0.000|FS:0,0|Pn:PZA>
Probe is triggered
$6=1
Probe is Physically Open
<Alarm|WPos:0.000,0.000,0.000,0.000|FS:0,0|Pn:PZA>
Probe is triggered
Probe is Physically Closed
<Alarm|WPos:0.000,0.000,0.000,0.000|FS:0,0|Pn:ZA>
Probe is not triggered