DynamoDB: Add software test for decoding list of objects #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amotl
commented
Aug 28, 2024
Comment on lines
+3
to
+18
| RECORD_UTM = { | ||
| "Id": {"N": "101"}, | ||
| "utmTags": { | ||
| "L": [ | ||
| { | ||
| "M": { | ||
| "date": {"S": "2024-08-28T20:05:42.603Z"}, | ||
| "utm_adgroup": {"L": [{"S": ""}, {"S": ""}]}, | ||
| "utm_campaign": {"S": "34374686341"}, | ||
| "utm_medium": {"S": "foobar"}, | ||
| "utm_source": {"S": "google"}, | ||
| } | ||
| } | ||
| ] | ||
| }, | ||
| } |
There was a problem hiding this comment.
Based on this input data (DynamoDB table record), and a SQL DDL like
CREATE TABLE IF NOT EXISTS foobar (data OBJECT(DYNAMIC));[...]
Comment on lines
+42
to
+54
| results = cratedb.database.run_sql("SELECT * FROM testdrive.demo;", records=True) # noqa: S608 | ||
| assert results[0]["data"] == { | ||
| "Id": 101.0, | ||
| "utmTags": [ | ||
| { | ||
| "date": "2024-08-28T20:05:42.603Z", | ||
| "utm_adgroup": ["", ""], | ||
| "utm_campaign": "34374686341", | ||
| "utm_medium": "foobar", | ||
| "utm_source": "google", | ||
| } | ||
| ], | ||
| } |
There was a problem hiding this comment.
.... that's the outcome that proves data converges into a CrateDB record well, afaics.
|
Thanks for acknowledging. It's just a software test. No code has been adjusted, so this will not yield or need another release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
People reported problems converging a list of objects from DynamoDB to CrateDB. Adding a test case to evaluate the situation.
References