Introducing a general support for native JSON serialization. #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alexandre-T
added a commit
to Alexandre-T/doctrine2-spatial
that referenced
this pull request
Mar 28, 2020
|
This request #209 which implements JsonSerializable. You could have a look at this fork. Deployed on packagist, a new package is now available for PHP7.2+ |
tugrul
reviewed
Jun 6, 2020
| */ | ||
| public function jsonSerialize() | ||
| { | ||
| return $this->toArray(); |
There was a problem hiding this comment.
Also type should be in the json data to make compatible to GeoJSON spec. Better implementation:
public function jsonSerialize()
{
return ['type' => $this->getType(), 'coordinates' => $this->toArray()];
}
tugrul
reviewed
Jun 6, 2020
| @@ -65,6 +65,14 @@ public function toJson() | |||
| return json_encode($json); | |||
There was a problem hiding this comment.
can replace to:
public function toJson()
{
return json_encode($this);
}
tugrul
suggested changes
Jun 6, 2020
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a rather simple patch that allows spatial data to be json-serialized through native PHP toolset. I am far from being 100% sure this patch covers all use cases, but it does mine (Symfony FOS rest bundle with a JSON content type).