Propagate existing CNI_ARGS to non-k8s consumers, e.g., podman

[space88man]

Let's try again. Add existing CNI_ARGS in the environment to rt.Args in case the caller is a non-k8s consumer like podman.

Addresses #65

[space88man]

/assign @sameo

[saschagrunert]

LGTM

[rhatdan]

@mheon @mrunalp PTAL

[space88man]

Bump - thank you.

[dcbw]

@squeed can you weigh in?

[squeed]

Hmm. We solved this a quite different way in rkt - you could do something like --net=myptp,FOO=BAR --net=myvlan,BAZ=BAR.

It would be good if podman itself decided what CNI_ARGS should be and passed them directly to oci-cni instead. If it wants to gather them from the environment, that's OK but not optimal (since it might have multiple networks). ocicni should probably not be adding additional args.

[rhatdan]

@mheon @mccv1r0 WDYT?

[space88man]

"ocicni should probably not be adding additional args." — in this use case, it is trying to propagate the existing env, since that got overwritten by the K8S* stuff.

[rhatdan]

@space88man @haircommander @mrunalp @dcbw @squeed @saschagrunert Is this still needed? Just trying to cleanup this Repo so we can do a release.

[rhatdan]

@space88man @haircommander @mrunalp @dcbw @squeed @saschagrunert Is this still needed? Just trying to cleanup this Repo so we can do a release.

[rhatdan]

@mheon @baude PTAL Do we need this?

[mheon]

It's not essential but it's definitely nice to have.

[mheon]

@mccv1r0 Can you take a quick look at this and verify the way the args are being passed looks correct?

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: mccv1r0, saschagrunert, space88man

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[space88man]

@space88man @haircommander @mrunalp @dcbw @squeed @saschagrunert Is this still needed? Just trying to cleanup this Repo so we can do a release.
Yes - I would like this to go in for pet pods.

[rhatdan]

/lgtm