Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade OpenSSL to 1.0.2p #180

Closed
wants to merge 6 commits into from
Closed

upgrade OpenSSL to 1.0.2p #180

wants to merge 6 commits into from

Conversation

bgermann
Copy link
Contributor

@bgermann bgermann commented Feb 8, 2018

No description provided.

@bgermann bgermann changed the title upgrade OpenSSL to 1.0.2n upgrade OpenSSL to 1.0.2o Mar 24, 2018
@jamesmunns
Copy link
Contributor

Thanks @bgermann!

@homunkulus r+

@jamesmunns
Copy link
Contributor

How about....

bors r+

bors bot added a commit that referenced this pull request Mar 24, 2018
180: upgrade OpenSSL to 1.0.2o r=jamesmunns a=bgermann
@jamesmunns
Copy link
Contributor

@bgermann it looks like the builds are failing because there is no 1.0.2o release.

I do not see a release here: https://www.openssl.org/source/, or even here: https:/openssl/openssl/releases

Do you want to roll back your last commit, and we can stick with 1.0.2n? Let me know if I am missing anything here.

@jamesmunns
Copy link
Contributor

See https://travis-ci.org/japaric/cross for more details

@bors
Copy link
Contributor

bors bot commented Mar 25, 2018

Build failed

@bgermann
Copy link
Contributor Author

It will be released on Tuesday.

@jamesmunns
Copy link
Contributor

Okay, we can wait until Tuesday. Feel free to @ me when 1.0.2o is released, and I can retrigger the CI (and hopefully get this merged).

@bgermann
Copy link
Contributor Author

@jamesmunns new OpenSSL versions are released.

@jamesmunns
Copy link
Contributor

bors r+

bors bot added a commit that referenced this pull request Mar 27, 2018
180: upgrade OpenSSL to 1.0.2o r=jamesmunns a=bgermann
@bors
Copy link
Contributor

bors bot commented Mar 27, 2018

Canceled

@jamesmunns
Copy link
Contributor

@bgermann whats up with the failing gen-tests? @japaric is this okay to remove?

@bgermann
Copy link
Contributor Author

bgermann commented Mar 29, 2018

The compiler_builtins crate does not have this feature anymore.

@Bobo1239
Copy link
Contributor

Bobo1239 commented Mar 30, 2018

@bgermann compiler_builtins moved their tests into a separate crate. To do testing you should do the same change as they did: rust-lang/compiler-builtins@2a13475#diff-4883bd4f2cfbef38c77abd7eca84ba27R45

btw: I don't think CI will pass just yet; there are multiple issues when trying to build the docker images at the moment. I'll try to open a PR with all fixes once everything is ready (current status):

@bgermann
Copy link
Contributor Author

Yes, I am also trying to fix the build. #189 is for the FTP issues.

@bgermann
Copy link
Contributor Author

bgermann commented Mar 30, 2018

Oh, and wait for cmake-rs to be released, containing rust-lang/cmake-rs@316dca50e0a4

Edit: done

@Bobo1239
Copy link
Contributor

Bobo1239 commented Mar 31, 2018

Update: The linking problems are still present :( (https://travis-ci.org/Bobo1239/cross/builds/360497698)
edit: New hope with rust-lang/rust#49672.
edit: https://travis-ci.org/Bobo1239/cross/builds/363731565; Now only rust-lang/rust#49627 and an undefined reference to _Unwind_Resume (i686-pc-windows-gnu) remain.

@bgermann
Copy link
Contributor Author

The libgit2/libgit2#4601 fix is in the latest git2-rs release.

@bgermann bgermann changed the title upgrade OpenSSL to 1.0.2o upgrade OpenSSL to 1.0.2p Aug 23, 2018
@bgermann
Copy link
Contributor Author

bgermann commented Oct 2, 2018

Closing this as it contains a fix that also is in #206. I will open a new PR when that PR is merged. Will this be 1.0.2q then...?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants