Help wanted! Here are some simple tasks that can be handled🎉.

[crossoverJie]

I have created some help want label issue, welcome friends who are interested to contribute!

Pick your favorite(s) and then remind me.

• Use @Slf4j instead of private final static Logger LOGGER@baiyina Use @Slf4j instead of private final static Logger LOGGER #137
• Translate all comments and logs into English.
• Create some unit test for cim-common.
• Client SDK @crossoverJie Client SDK #148.
• Integrated jacoco & codecov [test] fix-unit-test #142.
• Use curator instead of zkclient @crossoverJie Refactor Metastore #140.
• Use Spring IOC to refactor RpcProxyManager feature:Use_Spring_IOC_to_refactor_RpcProxyManager #154 @cmgyqjj
• Support swagger UI @baiyina 使用Knife4j 4.4代替接口文档 #136
• Support swagger.enable properties 使用Knife4j 4.4代替接口文档 #136 (comment).
• Use application.yaml instead of application.properties @baiyina Use application.yaml instead of application.properties #138.

Or if see any areas for improvement, feel free to submit a PR and submit🎉.

[baiyina]

@crossoverJie I'd like to take care of the first one "Use @Slf4j instead of private final static Logger LOGGER"

[baiyina]

@crossoverJie I'd like to take care of “Use application.yaml instead of application.properties.”

[cmgyqjj]

@crossoverJie I'd like to take care of "Use Spring IOC to refactor ProxyManager". I've noticed that ProxyManager has been deprecated in the latest branch. Are you referring to RPCProxyManager instead?
If I have understood the requirements correctly, we can add the injection of the corresponding API proxy objects under the BeanConfig in both cim-server and cim-client. Additionally, we should modify the invocation points to use injected instances instead of directly calling the create method. This approach will leverage the Spring IOC container to manage the lifecycle and dependencies of these proxy objects, ensuring a more maintainable and testable codebase.


[crossoverJie]

If I have understood the requirements correctly, we can add the injection of the corresponding API proxy objects under the BeanConfig in both cim-server and cim-client

Please update the latest code, the core logic of cim-client has been implemented by the cim-client-sdk, and currently only the route and server are directly using RpcProxyManager:

cim/cim-server/src/main/java/com/crossoverjie/cim/server/kit/RouteHandler.java

Lines 60 to 62 in 05ffa2d

	RouteApi routeApi = RpcProxyManager.create(RouteApi.class, configuration.getRouteUrl(), okHttpClient);
	ChatReqVO vo = new ChatReqVO(userInfo.getUserId(), userInfo.getUserName());
	routeApi.offLine(vo);

cim/cim-forward-route/src/main/java/com/crossoverjie/cim/route/service/impl/AccountServiceRedisImpl.java

Lines 152 to 155 in 05ffa2d

	String url = "http://" + cimServerResVO.getIp() + ":" + cimServerResVO.getHttpPort();
	ServerApi serverApi = RpcProxyManager.create(ServerApi.class, url, okHttpClient);
	SendMsgReqVO vo = new SendMsgReqVO(cimUserInfo.getUserName() + ":" + groupReqVO.getMsg(), groupReqVO.getUserId());
	serverApi.sendMsg(vo);

[cmgyqjj]

Please update the latest code, the core logic of cim-client has been implemented by the cim-client-sdk, and currently only the route and server are directly using RpcProxyManager:

cim/cim-forward-route/src/main/java/com/crossoverjie/cim/route/service/impl/AccountServiceRedisImpl.java

Lines 152 to 155 in 05ffa2d

	String url = "http://" + cimServerResVO.getIp() + ":" + cimServerResVO.getHttpPort();
	ServerApi serverApi = RpcProxyManager.create(ServerApi.class, url, okHttpClient);
	SendMsgReqVO vo = new SendMsgReqVO(cimUserInfo.getUserName() + ":" + groupReqVO.getMsg(), groupReqVO.getUserId());
	serverApi.sendMsg(vo);

Thank you for your response. In the route module, I've noticed that RpcProxyManager.create(ServerApi.class, url, okHttpClient); cannot be simply managed by IOC, as the url is a variable parameter. Is it necessary to implement with a FactoryBean? Or have I misunderstood the requirements?

[crossoverJie]

Thank you for your response. In the route module, I've noticed that RpcProxyManager.create(ServerApi.class, url, okHttpClient); cannot be simply managed by IOC, as the url is a variable parameter. Is it necessary to implement with a FactoryBean? Or have I misunderstood the requirements?

I have created a PR that can use dynamic url for a request #151.

Please update the latest code.