-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for ToEnvironmentFieldPath
patch type in spec.environment.patches
#123
Comments
truongnht
changed the title
support for
Support for May 25, 2024
ToEnvironmentFieldPath
patch type in spec.environment.patches
ToEnvironmentFieldPath
patch type in spec.environment.patches
Aha, I see what happened, when I refactored and properly splitted the patch types I introduced a breaking change inadvertently, as although they should have not been supported, they were actually working before. It could be fine supporting both ways to define those patches, ToEnvironment == FromCompositeFieldPath, FromEnvironment == ToCompositeFieldPath 🤔 |
truongnht
added a commit
to truongnht/function-patch-and-transform
that referenced
this issue
May 29, 2024
truongnht
added a commit
to truongnht/function-patch-and-transform
that referenced
this issue
May 29, 2024
truongnht
added a commit
to truongnht/function-patch-and-transform
that referenced
this issue
May 29, 2024
Resolves crossplane-contrib#123 Signed-off-by: Truong Nguyen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In
function-patch-and-transform
0.2.1 we do have support forToEnvironmentFieldPath
, so the following was supported in our compositionHowever in latest release the
ToEnvironmentFieldPath
patch type is no longer supported, ratherFromCompositeFieldPath
. Since our platform supports also customer compositions, it is not easy bringing breaking changes without verifying with all customers. Our ask is to bring back the support forTo|FromEnvironmentFieldPath
inspec.environment.patches
The text was updated successfully, but these errors were encountered: