update toFieldPath policies with options compatible to upstream mergeOptions #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ravilr
commented
Mar 28, 2024
ravilr
commented
- Updates feat: toFieldPath policies, replacing upstream MergeOptions #91
- Partially addresses Merge patch behavior not compatible with Native P&T #101 with native P&T compatible mergeOptions as per the proposal in Merge patch behavior not compatible with Native P&T #101 (comment)
negz
reviewed
Mar 28, 2024
ravilr
force-pushed
the
update_toFieldMergePolicies
branch
2 times, most recently
from
07f8711
to
5826eab
Compare
negz
approved these changes
Mar 28, 2024
|
@ravilr Aha, looks like the linter is complaining about the few uses of the newly deprecated types in the codebase. Could you update those too? I think they need a comment like: |
…Options Signed-off-by: ravilr <[email protected]>
ravilr
force-pushed
the
update_toFieldMergePolicies
branch
from
5826eab
to
566a3fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.