Bump Kubernetes deps, buf, and provider-aws #178
Conversation
These all had quite a lot of interactions so I had to do them together. Note we can't bump to Kubernetes v0.31.0 because it's newer than what the latest crossplane-runtime release is using. We'll need to update crossplane-runtime first. I'm also seriously questioning keeping the dependency on provider-aws. It's massive and has a lot of painful dependencies to fix when we update the import. On the other hand, I experimented with e.g. using provider-nop or provider-kubernetes for examples and didn't like it. Signed-off-by: Nic Cope <[email protected]>
| go.uber.org/zap v1.27.0 | ||
| google.golang.org/grpc v1.66.2 | ||
| google.golang.org/grpc/cmd/protoc-gen-go-grpc v1.5.1 | ||
| google.golang.org/protobuf v1.34.2 | ||
| google.golang.org/protobuf v1.34.3-0.20240816073751-94ecbc261689 |
There was a problem hiding this comment.
Any particular reason not to bump it just to 1.34.3?
There was a problem hiding this comment.
Not sure - this is just what the Go dependency solver decided on. 🤷
There was a problem hiding this comment.
Apparently it doesn't exist yet:
go: google.golang.org/[email protected]: invalid version: unknown revision v1.34.3
| buf.build/gen/go/bufbuild/protovalidate/protocolbuffers/go v1.33.0-20240221180331-f05a6f4403ce.1 // indirect | ||
| connectrpc.com/connect v1.15.0 // indirect | ||
| connectrpc.com/otelconnect v0.7.0 // indirect | ||
| buf.build/gen/go/bufbuild/bufplugin/protocolbuffers/go v1.34.2-20240904181154-a0be11449112.2 // indirect |
There was a problem hiding this comment.
Nit: We should probably do the same we are doing for Crossplane snd just run it without importing it
There was a problem hiding this comment.
I'm not sure how I feel about that workaround TBH. The latest version of buf seemed to work fine here. If they stop breaking us I'd prefer to install them as a dependency like we do with other tools.
There was a problem hiding this comment.
The issue is not whether it works, but the fact that they pull in a bunch of dependency that often conflict with stuff we care about, like Kubernetes dependencies
Description of your changes
Closes #125
Closes #134
Closes #175
These all had quite a lot of interactions so I had to do them together.
Note we can't bump to Kubernetes v0.31.0 because it's newer than what the latest crossplane-runtime release is using. We'll need to update crossplane-runtime first.
I'm seriously questioning keeping the dependency on provider-aws. It's massive and has a lot of painful dependencies to fix when we update the import. On the other hand, I experimented with e.g. using provider-nop or provider-kubernetes for examples and didn't feel they provided as clear an example as using an S3 bucket. They also didn't improve as much on the dependency pains as I'd hoped.
I have:
make reviewableto ensure this PR is ready for review.