Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: miss keypair of SendEnabled to restore legacy param set before migration #1206

Merged
merged 5 commits into from
Oct 16, 2023

Conversation

mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Oct 13, 2023

…re migration

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: mmsqe <[email protected]>
go.mod Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Merging #1206 (8454288) into main (f48d42e) will increase coverage by 31.46%.
The diff coverage is n/a.

❗ Current head 8454288 differs from pull request most recent head 6307a31. Consider uploading reports for the commit 6307a31 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1206       +/-   ##
===========================================
+ Coverage   16.70%   48.16%   +31.46%     
===========================================
  Files          79       74        -5     
  Lines        5766     6193      +427     
===========================================
+ Hits          963     2983     +2020     
+ Misses       4725     2893     -1832     
- Partials       78      317      +239     

see 101 files with indirect coverage changes

@mmsqe mmsqe marked this pull request as ready for review October 13, 2023 07:28
@mmsqe mmsqe requested a review from a team as a code owner October 13, 2023 07:28
@mmsqe mmsqe requested review from calvinaco and devashishdxt and removed request for a team October 13, 2023 07:28
go.mod Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants