Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: sdk v0.47.x is outdated #1272

Merged
merged 3 commits into from
Dec 22, 2023
Merged

Conversation

mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Dec 21, 2023

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

For more info:

cometbft/cometbft@46df7b5...v0.37.4
crypto-org-chain/cosmos-sdk@eec0174...7b15830
crypto-org-chain/ethermint@aaff96b...aff52db

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Summary by CodeRabbit

  • Documentation

    • Updated the CHANGELOG.md to reflect the latest versions of dependencies.
  • Chores

    • Updated ethermint to the latest development version.
    • Upgraded cosmos-sdk to version v0.47.7.

Copy link
Contributor

coderabbitai bot commented Dec 21, 2023

Walkthrough

The project has updated its dependencies, notably upgrading ethermint and the cosmos-sdk to version v0.47.7. This change likely enhances the project's features, stability, or compatibility with the broader ecosystem, although it does not introduce any new publicly exported entities.

Changes

File(s) Change Summary
.../go.mod Updated ethermint to the latest development version and cosmos-sdk to v0.47.7.

🐇✨
In the code's woven tapestry,
A thread was added, fine and free.
New versions spun, so deftly laced,
In digital meadows, they're embraced. 🌿🌟

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ?


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • You can reply to a review comment made by CodeRabbit.
  • You can tag CodeRabbit on specific lines of code or files in the PR by tagging @coderabbitai in a comment.
  • You can tag @coderabbitai in a PR comment and ask one-off questions about the PR and the codebase. Use quoted replies to pass the context for follow-up questions.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: mmsqe <[email protected]>
@mmsqe mmsqe marked this pull request as ready for review December 21, 2023 07:07
@mmsqe mmsqe requested a review from a team as a code owner December 21, 2023 07:07
@mmsqe mmsqe requested review from JayT106 and calvinaco and removed request for a team December 21, 2023 07:07
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between b47e5c1 and 149c8f9.
Files ignored due to filter (3)
  • go.mod
  • go.sum
  • gomod2nix.toml
Files selected for processing (1)
  • CHANGELOG.md (1 hunks)
Additional comments: 1
CHANGELOG.md (1)
  • 6-6: The addition to the UNRELEASED section correctly follows the established format of the changelog entries and provides a clear reference to the pull request related to the update. This entry should help users understand the changes that will be included in the next release.

@mmsqe mmsqe enabled auto-merge December 22, 2023 01:34
Copy link

codecov bot commented Dec 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b47e5c1) 16.02% compared to head (884761d) 35.81%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1272       +/-   ##
===========================================
+ Coverage   16.02%   35.81%   +19.78%     
===========================================
  Files          80      116       +36     
  Lines        6184    10653     +4469     
===========================================
+ Hits          991     3815     +2824     
- Misses       5114     6462     +1348     
- Partials       79      376      +297     

see 54 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants