Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: failed tx are ignored in json-rpc apis (backport #502) #503

Merged
merged 2 commits into from
Jun 14, 2022
Merged

Problem: failed tx are ignored in json-rpc apis (backport #502) #503

merged 2 commits into from
Jun 14, 2022

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented May 24, 2022

Solution:

  • fix the issue in ethermint by emitting extra events in ante handler.
  • add integration test to test it.
  • update cosmos-sdk dependency

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

yihuang
yihuang commented May 24, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
yihuang
yihuang commented May 24, 2022
View reviewed changes
go.mod Outdated Show resolved Hide resolved
yihuang
yihuang commented May 24, 2022
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@yihuang yihuang mentioned this pull request May 31, 2022
Merged
13 tasks
@yihuang yihuang force-pushed the emit-tx-hash-backport branch 3 times, most recently from 44e01c2 to 88981bb Compare June 6, 2022 02:44
@yihuang yihuang marked this pull request as ready for review June 6, 2022 03:14
@yihuang yihuang requested a review from a team as a code owner June 6, 2022 03:14
@yihuang yihuang requested review from devashishdxt and adu-crypto and removed request for a team June 6, 2022 03:14
yihuang
yihuang commented Jun 6, 2022
View reviewed changes
go.mod Show resolved Hide resolved
@yihuang yihuang requested a review from thomas-nguy June 6, 2022 09:52
yihuang
yihuang commented Jun 6, 2022
View reviewed changes
go.mod Outdated Show resolved Hide resolved
yihuang
yihuang commented Jun 10, 2022
View reviewed changes
go.mod Show resolved Hide resolved
@yihuang
Problem: failed tx are ignored in json-rpc apis (backport crypto-org-…
b90b527 
…chain#502)

Solution:
- fix the issue in ethermint by emitting extra events in ante handler.
- add integration test to test it.
- update cosmos-sdk dependency
- fix getTransactionReceiptsByBlock

fix integration test

move to crypto-org-chain repo

Update CHANGELOG.md

update cosmos-sdk to most recent

cosmos-sdk v0.45.5

Problem: gravity bridge integration test fails occasionally (crypto-org-chain#538)

* Problem: gravity bridge integration test fails occasionally

WIP: crypto-org-chain#48

- Add traceback env var to debug

* run ibc test together

* avoid port conflict

* Update scripts/run-integration-tests
thomas-nguy
thomas-nguy approved these changes Jun 14, 2022
View reviewed changes
Copy link
Collaborator

@thomas-nguy thomas-nguy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approved the PR but there are a lot of diff between cosmossdk v0.45.4 and v0.45.5 (especially some errors message on some util functions that may cause undesirable behavior)

Before merge, better test the binary and check that no app hash mismatch can happen

@yihuang
Copy link
Collaborator Author

yihuang commented Jun 14, 2022

I approved the PR but there are a lot of diff between cosmossdk v0.45.4 and v0.45.5 (especially some errors message on some util functions that may cause undesirable behavior)

Before merge, better test the binary and check that no app hash mismatch can happen

yeah, we'll go through the qa process too when we release the v0.7.1.

@yihuang yihuang merged commit 75c2672 into crypto-org-chain:release/v0.7.x Jun 14, 2022
@yihuang yihuang deleted the emit-tx-hash-backport branch June 14, 2022 03:51
@coderabbitai coderabbitai bot mentioned this pull request Apr 19, 2024
Merged
13 tasks
This was referenced Apr 26, 2024
Merged
Merged
Merged
Merged
Merged
This was referenced Apr 30, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomas-nguy thomas-nguy thomas-nguy approved these changes

@devashishdxt devashishdxt Awaiting requested review from devashishdxt devashishdxt is a code owner automatically assigned from crypto-org-chain/cronos-dev

@adu-crypto adu-crypto Awaiting requested review from adu-crypto adu-crypto is a code owner automatically assigned from crypto-org-chain/cronos-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yihuang @thomas-nguy