-
-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor resolver code #574
Labels
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The three resolvers git, hg and fossil share a lot of very similar code. The latter ones are both based on the git implementation.
Just copying the code was nice for getting started. But that much duplication carries a technical debt. It's hard to keep track of things, especially when there are slight differences between the implementations, some of them seemingly arbitrary. The code should be consolidated, and similar pieces merged together.
Two recently fixed bugs #569 and #573 only existed in the git resolver. The other two used basically the same code, but with the bugs already fixed. The fixes were never brought back to the git resolver, though.
I think quite a bit of shared functionality can be abstracted and put in a general utility module.
A major common aspect is the CLI, running processes with error handling etc.
The text was updated successfully, but these errors were encountered: