Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug-Candidate]: Echidna multicore produces slower shrinking behavior #1105

Closed
aviggiano opened this issue Aug 16, 2023 · 3 comments · Fixed by #1280
Closed

[Bug-Candidate]: Echidna multicore produces slower shrinking behavior #1105

aviggiano opened this issue Aug 16, 2023 · 3 comments · Fixed by #1280
Labels
Milestone

Comments

@aviggiano
Copy link

aviggiano commented Aug 16, 2023

Describe the issue:

I am running echidna with 8 workers, but I am getting unexpected/unwanted results for the shrinking step when a bug is found:

Instead of shrinking faster, when I add more workers the process is significantly slower.

Sometimes I see the shrink step go down, and then up, then down, and then up. It seems like increasing the number of workers adds a bunch of (duplicate) transactions that do not contribute to the smallest sequence possible.

I did a small 1-min test, reutilizing the corpus, with 1 worker vs 8 workers. You can see below that using more workers makes echidna run much slower when a bug is found.

1 worker

Screenshot 2023-08-16 at 15 52 02

8 workers

Screenshot 2023-08-16 at 15 49 21

Code example to reproduce the issue:

N/A

Version:

Echidna 2.2.1
slither 0.9.2

Relevant log output:

N/A
@rappie
Copy link

rappie commented Aug 19, 2023

I often encounter the same thing. I think this is because the different workers can overwrite each others "best shrunk" version and kind of work against each other that way.

@arcz arcz added the bug label Aug 21, 2023
@arcz
Copy link
Member

arcz commented Aug 21, 2023

Yes, this is a known issue to be fixed

@ggrieco-tob
Copy link
Member

I think minimization should be restricted to a single worker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants