Many light sources appear to be missing.

[AmphetamineRush]

After playing back and forth between this and the original, it looks like there's a lot of texture lights that aren't appearing as raycast light sources. Specfically it may be ones that have a lightmap animation or trigger. Also ones that are attached to moving objects like switches and lifts. Net result is that the game is pitch black in places that it shouldn't be and especially in some places where a switch should be the bright focal point of the room.

Thank you for releasing this btw, it's an amazing project.

Also is it possible to implement some sort of dynamic resolution support tied to a framerate target?

[cschied]

Hi,

yes the heuristics for detecting light sources are not complete, unfortunately. It looks for some info in the bsp to detect lights but that seems to be missing a lot of them.
I therefore additionally added a list of textures to mark as lights:

q2vkpt/src/refresh/vkpt/textures.c

Line 429 in a4de8e9

/* we match on radiance in the bsp, unfortunately this

You can add additional textures there.

As for the dynamic bsp lights: The indices in the instance buffer need to be added to the light list here but for that to work as expected the bsp entity meshes need to be separated into lights and non-lights here

[AmphetamineRush]

I'm no coder, unfortunately, but I did remember enough about Q2 level building to be able to decompile the base maps and take a look at them in GTKRadiant. That is when I realised that I'm wrong and all the missing lights are entity point lights. They're everywhere, little cheats to try and fake the look of natural lighting :(

In terms of lighting up dark places that don't have a surface light present, maybe make a function in Q2VKPT to apply a small decal light to the surface under the reticule and save the location information to an external file that can be distributed with the port?