Skip to content
This repository has been archived by the owner on Jan 20, 2024. It is now read-only.

feat: (added authentication with social) #94

Closed
wants to merge 6 commits into from

Conversation

AdityaPainuli
Copy link
Contributor

Added Social Account Authentication with Github and Google.

Here are some screenshots of the Website: -

image
image

@vercel
Copy link

vercel bot commented Aug 16, 2022

Someone is attempting to deploy a commit to a Personal Account owned by @ykdojo on Vercel.

@ykdojo first needs to authorize it.

Copy link
Contributor

@rohitdasu rohitdasu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add docs in readme.md file for google and github auth setup in supabase

@rohitdasu rohitdasu linked an issue Aug 16, 2022 that may be closed by this pull request
@iShibi
Copy link
Contributor

iShibi commented Aug 16, 2022

@AdityaPainuli Your lockfile is out of sync again. Delete package-lock.json and run npm i to sync it. Also, make sure not to work directly in the main branch from now on. Once this PR is merged run git pull upstream main and checkout a new branch for any future PR.

@vercel
Copy link

vercel bot commented Aug 16, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
defaang ✅ Ready (Inspect) Visit Preview Aug 22, 2022 at 4:03AM (UTC)

@ykdojo
Copy link
Collaborator

ykdojo commented Aug 16, 2022

I think we should remove "Sign In using other social networks" and "Sign up using other social networks" to keep the UI simple.

@AdityaPainuli
Copy link
Contributor Author

I think we should remove "Sign In using other social networks" and "Sign up using other social networks" to keep the UI simple.

If it's okay with all of you then we should remove it .

@ykdojo
Copy link
Collaborator

ykdojo commented Aug 19, 2022

please add docs in readme.md file for google and github auth setup in supabase

Did you address this yet?

@AdityaPainuli
Copy link
Contributor Author

I am waiting to get approval from all the members about social authentication if you all agree on this then I will start adding docs.

@ykdojo
Copy link
Collaborator

ykdojo commented Aug 20, 2022

I think the general idea is good, but it'll be good to have documentation for it

@AdityaPainuli
Copy link
Contributor Author

Alright then I will work on the documentation

@AdityaPainuli
Copy link
Contributor Author

Hey as I am writing the docs for authentication through a social platform I think it will be easy to attach a video to it as it is a bit of work on the cloud console and GitHub developer page. Can I add the video to the readme? Because without video the readme will become very long which I don't think is good

@ykdojo
Copy link
Collaborator

ykdojo commented Aug 21, 2022

Yes the video would be great. Thank you!

@AdityaPainuli
Copy link
Contributor Author

Here is the video for both authentication . As Github has a limit of 10MB of media I tried to keep the quality lower for both of the videos.
https://user-images.githubusercontent.com/66621672/185778299-9ef3b994-2889-485b-bd39-b2ea20fa305f.mp4

github.mp4

@ykdojo
Copy link
Collaborator

ykdojo commented Aug 21, 2022

Thank you! Did you add it in README?

@AdityaPainuli
Copy link
Contributor Author

Added the videos to README

@ykdojo
Copy link
Collaborator

ykdojo commented Aug 22, 2022

Thank you. This looks good, but I never realized it would take so much work to set up Google/GitHub signups.

Given that, I think it makes sense to hold off on merging this PR so we can merge it later when we have a properly working product.

So could you please make it a draft PR for now?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add multiple ways for authentication
4 participants