-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for python <3.8? #7
Comments
Noting for discussion that Python 3.7 will be EOL in less than 12 months from now (on 2023-06-27)... I agree we should either support python 3.7 while it is still a supported version OR have a clear statement that we require python>=3.8. If we're going to support 3.7 properly, though, then that would require downgrading some of the emsarray dependencies, as several of the critical ones have already dropped python 3.7 support:
I'm reluctant to lock ourselves into older versions of things like xarray, as that would mean we can't take advantage of new features in that library as they're released (and also, security scanners get whiny about known vulnerabilities). @blasee what is your use case for needing python 3.7? Any chance of a platform upgrade at your end? |
@sharon-tickell I agree downgrading dependencies is not ideal at all. We certainly have the ability to upgrade python at our end so it seems that's the best option, I didn't quite realise how old 3.7 actually was. I'll close this issue, thanks for your reply! |
Hey @mx-moth,
Thanks again for developing this package. I'm running into the following error when importing
emsarray
using python 3.7:It turns out that
importlib
only has ametadata
submodule starting from python 3.8. Thejsonschema
package uses the following code to circumvent this issue.which of course requires the installation of the
importlib_metadata
package.Is this something that could be implemented in
emsarray
too?The text was updated successfully, but these errors were encountered: