修正获取图片资源绝对路径Bug #41
Open
修正获取图片资源绝对路径Bug #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
好的，非常感谢，我抽时间 review 一下后 merge。 |
|
建议新增一个配置项，告诉代码该去哪里寻找绝对路径的根目录，默认值为process.cwd() 然后path.join(option.rootPath || process.cwd(), sourcePath) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
环境OS X10.11/node 0.12.7，当background-image的url使用绝对地址时（如：background: url(/resource/foo.png) ），getAbsolutePath函数拿到的sourcePath参数首位字符是”/“，这会导致path.resolve认为sourcePath是文件系统root上的目录。