Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose public typings for plugins and abstractions like react-jss #777

Closed
kof opened this issue Jul 18, 2018 · 1 comment
Closed

Expose public typings for plugins and abstractions like react-jss #777

kof opened this issue Jul 18, 2018 · 1 comment
Labels
complexity:moderate We talked about it, you can do it! feature request This will safe many lifes! important The thing you do when you wake up!

Comments

@kof
Copy link
Member

kof commented Jul 18, 2018

For plugins and for e.g. react-jss we need the typings and its better to reuse them rather than duplicating.

Exporting all typings we have in the core would expose many private things, mb we should export only typings that we know are needed.
@kof kof added important The thing you do when you wake up! feature request This will safe many lifes! complexity:moderate We talked about it, you can do it! labels Jul 18, 2018
kof referenced this issue in gomesalexandre/react-jss Jul 18, 2018
@gomesalexandre
Type fixes following @kof and @HenriBeck reviews
ef4819a
@HenriBeck HenriBeck mentioned this issue Jul 18, 2018
Merged
@kof
Copy link
Member Author

kof commented Oct 27, 2018

Subscribe #795 for updates about release date.

@kof kof closed this as completed Oct 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
complexity:moderate We talked about it, you can do it! feature request This will safe many lifes! important The thing you do when you wake up!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kof