Handle callback error in readAsTextAsync & check CRC #232
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I found some issues around
readAsTextAsync
:readAsTextAsync
passes a callback down togetDataAsync
but only checks for a non-emptydata
object:adm-zip/adm-zip.js
Line 116 in 3f00a03
Then
getDataAsync
passes down that callback todecompress
:adm-zip/zipEntry.js
Line 245 in 3f00a03
Then
decompress
can invoke that callback with non-empty (!)data
and anerror
string:adm-zip/zipEntry.js
Line 62 in 3f00a03
So this PR just handles that potential error that can propagate up. Then I also added some tests around zips with good/bad CRCs. Also found that CRC check wasn't failing on zips with deliberately bad corrupted CRCs.