Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Beginning refactoring of ParseRouteUtils #199

Merged
merged 1 commit into from
Mar 12, 2019
Merged

Beginning refactoring of ParseRouteUtils #199

merged 1 commit into from
Mar 12, 2019

Conversation

young-k
Copy link
Contributor

@young-k young-k commented Mar 12, 2019 •
edited
Loading

Some quality of life changes for #195, more complicated refactoring will come soon:

  • Changed adjustRouteTimesIfNecessary to return an Object
  • Changed condenseRoute params to not have defaults, since the single callee provides parameters
  • Added helpers to reduce LOC in parseWalkingRoute and parseBusRoutes
  • Added documentation and types to functions that were missing
  • Alphabetized imports at top

Verified that all changes work on devserver.

ilikesymmetry
ilikesymmetry approved these changes Mar 12, 2019
View reviewed changes
Copy link

@ilikesymmetry ilikesymmetry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

kevinchan159
kevinchan159 approved these changes Mar 12, 2019
View reviewed changes
Copy link
Contributor

@kevinchan159 kevinchan159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@young-k young-k merged commit 9f8c6d8 into master Mar 12, 2019
@young-k young-k deleted the young/refactor-parse-routeutils branch March 12, 2019 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinchan159 kevinchan159 kevinchan159 approved these changes

@ilikesymmetry ilikesymmetry ilikesymmetry approved these changes

@alanna-zhou alanna-zhou Awaiting requested review from alanna-zhou

@meganle meganle Awaiting requested review from meganle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@young-k @kevinchan159 @ilikesymmetry