Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip date of milliseconds to fix 4:07 error #301

Merged
merged 2 commits into from
Aug 28, 2020
Merged

Conversation

alanna-zhou
Copy link
Contributor

Overview

The date time we get from TCAT has changed format sometime over the summer. They now include milliseconds unfortunately. We need to revert this format back to what it was so that clients don't break.

Date format we had before that we should maintain: yyyy-MM-dd'T'HH:mm:ssZZZZ
Date format that TCAT changed to over the summer: yyyy-MM-dd'T'HH:mm:ss.SSSZ

Changes Made

  • Stripped milliseconds off dates from TCAT if they exist
  • Updated docker-compose.yml so we can run things locally with this change
  • Updated the ghopper Dockerfile because Tom sent me data manually (can't fetch from the URL) so to keep versions matching with docker images, we should have master keep this change--once we can start fetching again (Aug 30), I'll update master

Test Coverage

  • Currently deployed on prod and dev from my branch and all is well
    • A temp fix similar to this one is currently deployed on prod from my branch as transit-node:v1.1.4
    • This PR fix is currently deployed on dev as transit-dev:date
  • We need to add a test on integration that ensures that our date formats are correct! Made an issue on the integration repo here.

Screenshots

Error on the left, fix on the right

Copy link
Contributor

@Omarrasheed Omarrasheed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm ty for fixing fam

Copy link
Contributor

@aliciaxw aliciaxw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice, thx for ur hard work as always!

Copy link

@whoiswillma whoiswillma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@alanna-zhou alanna-zhou merged commit adffe7d into master Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants