Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Firebase JavaScript SDK #208

Open
zachseidner1 opened this issue Sep 6, 2024 · 1 comment
Open

Remove Firebase JavaScript SDK #208

zachseidner1 opened this issue Sep 6, 2024 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers tech debt

Comments

@zachseidner1
Copy link
Contributor

zachseidner1 commented Sep 6, 2024

Currently, Resell uses both the JavaScript Firebase SDK and the React Native Firebase library.

Based on the recent sign in bug, the JavaScript Firebase SDK behaves doesn't work so it should not be in use. Any part of our app that uses this fails, so we need to refactor this when we can. We also need some specific functionality of React Native Firebase, so since we are using that anyway, we should not have this inconsistency where we are relying on 2 different Firebase SDKs throughout the app.

We should completely remove the dependency on the JS Firebase SDK. You'll need to change firebase.js and other files that depend on it.

Let's start on this after we completely confirm that the JS Firebase SDK was causing the login issue though.

@zachseidner1 zachseidner1 added the bug Something isn't working label Sep 6, 2024
@zachseidner1
Copy link
Contributor Author

it is mostly removed, ideally we should still completely remove it at some point. We still rely on it for auth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers tech debt
Projects
None yet
Development

No branches or pull requests

2 participants