Java optional codegen with final fields #1879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpkorstanje
reviewed
Jan 23, 2022
mpkorstanje
reviewed
Jan 23, 2022
mpkorstanje
reviewed
Jan 23, 2022
|
I've cleaned up the public API of gherkin, messages and the html formatter, added null checks. Other then the comments above I don't have anything else that needs to be fixed while we're doing a new major version. |
|
Split the files and put the messages back in I think we're good, but let's squash merge this. The intermediate commits are very noisy. |
|
Wooot great work @mpkorstanje |
This was referenced Feb 5, 2022
mpkorstanje
added a commit
to cucumber/html-formatter
that referenced
this pull request
Apr 3, 2022
mpkorstanje
added a commit
to cucumber/html-formatter
that referenced
this pull request
Apr 3, 2022
mpkorstanje
added a commit
to cucumber/html-formatter
that referenced
this pull request
Apr 3, 2022
mpkorstanje
added a commit
to cucumber/html-formatter
that referenced
this pull request
Apr 5, 2022
Co-authored-by: aurelien-reeves <[email protected]>
mpkorstanje
added a commit
to cucumber/cucumber-jvm
that referenced
this pull request
Apr 19, 2022
With cucumber/common#1879 `messages` now uses `Optional<T>` for optional types avoiding some unexpected null references. This resulted in some updating of `gherkin` and `html-formatter`. Additionally with this change the dependency on Jackson has been removed from `messages`. However we still have to serialize the message objects into json. So for now Jackson is shaded into `core` instead. And eventually we'll be able to spin this out to it's own module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supersedes #1858 with suggestions made by @mpkorstanje in #1858 (comment)
The code compiles, but the tests are failing because the classes don't have an empty constructor. I have enabled
<parameters>true</parameters>for the compiler plugin as suggested in #1858 (comment), but it doesn't seem to help.