-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
format: add support for gherkin rule/example syntax #1273
Conversation
The happy path for JSON formatter is working, moving on to failure cases and other built-in formatters, a couple of bits I am unsure of (above) which can be circled back to. |
@charlierudolph this is ready to go now I think. In the end it was mostly about changing gherkin document helper to be able to handle the rule/example structure when matching up from pickles, and some usage of this in the JSON formatter - beyond that it's just adding/changing tests on the other formatters to confirm they work normally, and adding some acceptance-level coverage as well. Let me know if you think anything is missing. |
@charlierudolph this will probably need a rebase after #1286 goes in, but otherwise is it okay? |
@charlierudolph feedback addressed and latest changes from master merged in here |
After the move to Gherkin 9 and cucumber-messages, we can execute specs that include Rule/Example syntax, but still need to update the formatter helpers and built-in formatters to handle the results.