attachments: support attaching already-encoded base64 content #1552
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1550.
After the refactor to accomodate messages, we made it impossible to attach content that was already base64 encoded, since passing a string and mime type to the
attach
function will cause it to be set as "identity".This makes it possible via a prefix on the mime type parameter e.g.
base64:image/png
. I'm not particularly wedded to this solution but it seems reasonable. Things we could do instead:attach
functionthis.attachBase64