Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support latest Mapbox GL JS (v1.13.0) #43

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

OttyLab
Copy link

@OttyLab OttyLab commented Nov 22, 2020

Summary

This pull request updated Mapbox GL JS version to the latest v1.13.0

Why?

Latest Mapbox GL JS supports latest styles like Mapbox Streets-v11 Style

@OttyLab
Copy link
Author

OttyLab commented Nov 23, 2020

@cvalenzuela @LukasDrgon
Could you review it when you have time? Thanks!

@Metriximor
Copy link

Yes, the latest version also allows for a pitch higher than 85 which is necessary in my case

@oneandonlyoddo
Copy link

Works for me! Can this be merged please?

@Metriximor
Copy link

Just a heads up there is a newer Mapbox GL version(2.0.1) than the one this PR uses

@OttyLab
Copy link
Author

OttyLab commented Feb 1, 2021

@Metriximor
Yes, v2.0.1 added some nice feature such as 3D view, free camera and sky layer. However it also changed the license; Mapbox access token is mandatory now. This means that even if the user does not host their data on Mapbox, they need to get Mapbox account and are charged according to the usage.

This might not be suitable for the uses of this library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants