Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add google geocode lookup/create/edit as github/npm component importable into cwrc-writer entity dialogs #11

Open
jchartrand opened this issue Aug 24, 2017 · 9 comments

Comments

@jchartrand
Copy link
Collaborator

https://developers.google.com/maps/documentation/geocoding/intro

@jchartrand jchartrand self-assigned this Aug 25, 2017
@jchartrand
Copy link
Collaborator Author

So, as far as I can tell, looking at this today, the Google Geocoding Service is meant to be used with Google Maps.

From https://developers.google.com/maps/documentation/geocoding/start :

"Geocoding is the process of converting addresses (like "1600 Amphitheatre Parkway, Mountain View, CA") into geographic coordinates (like latitude 37.423021 and longitude -122.083739), which you can use to place markers or position the map."

The Geocoding also returns a Google ‘place id’ (https://developers.google.com/places/place-id), which is not, however, a URI.

Form that site, "Place IDs uniquely identify a place in the Google Places database and on Google Maps”

A place id looks like: ChIJPar2cpiILIgR3Nn4G5_bzDo.

I’m happy for someone else to tell me if I’m looking at the wrong site, or have overlooked something.

@ilovan
Copy link

ilovan commented Feb 12, 2018

I believe the version of GeoCode installed in the old CWRC-Writer lookups was searching for the address (it had search suggestion / autocomplete) enabled and no disambiguation box. Can we go with that set up here?

@jchartrand
Copy link
Collaborator Author

jchartrand commented Feb 12, 2018 via email

@jchartrand
Copy link
Collaborator Author

jchartrand commented Feb 12, 2018 via email

@ilovan
Copy link

ilovan commented Feb 12, 2018

It looks like the option described by them is more likely to stay consistent:

So, like:

https://maps.googleapis.com/maps/api/place/details/json?placeid=ChIJN1t_tDeuEmsRUsoyG83frY4&key=YOUR_API_KEY

which returns info about the place. But, as you can see, an api key is needed, so again using that url doesn’t seem all that useful.

So if I get this straight, we should be able to use that URL within CWRC, but if someone else wanted to use it in a different context, they would need to provide their own API key? (apologies if I am being dense here)

@jchartrand
Copy link
Collaborator Author

jchartrand commented Feb 12, 2018 via email

@ilovan
Copy link

ilovan commented Feb 12, 2018

Hm, I get it now why Michael and Jeff decided in the past to go with https://www.google.ca/maps/place/Guelph,ON,Canada, even if this is also not-technically-an -identifiers, also.

I think @SusanBrown should probably weigh in here as well.

@jchartrand
Copy link
Collaborator Author

jchartrand commented Feb 12, 2018 via email

@ilovan
Copy link

ilovan commented Feb 12, 2018 via email

@ilovan ilovan added the Blocked label Aug 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants