Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browse map links on Conversion website broken #32

Open
RobJN opened this issue Sep 20, 2019 · 2 comments
Open

Browse map links on Conversion website broken #32

RobJN opened this issue Sep 20, 2019 · 2 comments
Labels

Comments

@RobJN
Copy link

RobJN commented Sep 20, 2019

Issue:

Links don't return the expected data.

How to reproduce:

  1. Go to https://bikedata.cyclestreets.net/tflcid/conversion/
  2. Scroll down to Feeder Lane in Centre
  3. Click the Browse map link.
  4. Gives the following URL: https://bikedata.cyclestreets.net/tflcid:type=advanced_stop_line&field%3Aasl_fdcent=TRUE/#15/51.5095/-0.1036/opencyclemap

Expected result:

Should be this URL: https://bikedata.cyclestreets.net/tflcid:field%3Aasl_fdcent=TRUE/#15/51.5095/-0.1036/opencyclemap

That is the URL you get if you use the https://bikedata.cyclestreets.net site to manually pick the data using the drop down menus on the right.

P.S. As a consequence of this bug I have potentially given bad notes in issues cyclestreets/tflcid-conversion#1 and cyclestreets/tflcid-conversion#2. I will review these again.

@mvl22
Copy link
Member

mvl22 commented Oct 11, 2019

Yes, sorry, this is a bug in the Bikedata code - basically it's not yet picking up the parameter when there's a second-level dynamic menu.

@mvl22
Copy link
Member

mvl22 commented Jul 31, 2022

I'm moving this issue over to the Bikedata repository as it's really a JS problem for the layer implementation there.

This will unfortunately be quite hard to solve...

@mvl22 mvl22 transferred this issue from cyclestreets/tflcid-conversion Jul 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants