Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off flake8-bugbear check 038 becuase it gave false positives. #5925

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

wxtim
Copy link
Member

@wxtim wxtim commented Jan 16, 2024

See PyCQA/flake8-bugbear#451

The following files fail the new flake8-bugbear B038 check:

  • The two cases in async_util are probably legitimate exceptions to the rule, parly because they are while loops using the modification to empty an object.
  • The one in broadcast_report is also using a while loop, but might not need to: It's not a quick fix though - it's 9 YO code and as far as I can see has no unit tests. IMO needs a suite of unit tests existing behaviour before changing. Not a quick win.
  • The one is in network/scan.py and option_parsers.py are the result of the bug.

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.
  • This change doesn't require any public facing docs.
  • Create an issue to undo this when:
    • Bugbear have fixed their issue.
    • When we have time to devote to the other three issues.

@wxtim wxtim self-assigned this Jan 16, 2024
@wxtim wxtim added this to the 8.2.x milestone Jan 16, 2024
@oliver-sanders oliver-sanders removed their request for review January 16, 2024 15:29
@MetRonnie MetRonnie merged commit df4e17d into cylc:8.2.x Jan 16, 2024
24 of 25 checks passed
@wxtim wxtim deleted the fix.bugbear.24.1.15-breakage branch January 17, 2024 07:40
@wxtim wxtim mentioned this pull request Jan 17, 2024
@oliver-sanders oliver-sanders modified the milestones: 8.2.x, cylc-8.2.5 Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants