Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pool: update the runahead limit after task removal #6428

Open
wants to merge 1 commit into
base: 8.3.x
Choose a base branch
from

Conversation

oliver-sanders
Copy link
Member

@oliver-sanders oliver-sanders commented Oct 17, 2024

Whilst writing the test, I noticed the n-window values for the "bar" tasks look wrong to me, although that's a different issue.

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • Changelog entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@oliver-sanders oliver-sanders added the bug Something is wrong :( label Oct 17, 2024
@oliver-sanders oliver-sanders added this to the 8.3.6 milestone Oct 17, 2024
@oliver-sanders oliver-sanders self-assigned this Oct 17, 2024
* Also closes cylc#4983 (by adding a test for it)
@@ -0,0 +1 @@
Ensure the runahead limit is recomputed when legacy "suicide-triggers" are used to prevent erroneous stall in niche cases.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Ensure the runahead limit is recomputed when legacy "suicide-triggers" are used to prevent erroneous stall in niche cases.
Ensure the runahead limit is recomputed when legacy "suicide-triggers" are used, to prevent erroneous stall in niche cases.

(A bit ambiguous without the comma)

@hjoliver
Copy link
Member

Whilst writing the test, I noticed the n-window values for the "bar" tasks look wrong to me, although that's a different issue.

Needs an issue?

@oliver-sanders
Copy link
Member Author

Needs an issue?

I think so, just checking that it's wrong before doing so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong :( small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

data store: blocked tasks outside of n=1 are missing from the store
2 participants