[UI] modules.php : Modify the text to explain that Cypht supports JMAP (RFC8621) by default. #1277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bienvenumoringa
force-pushed
the
promote-jmap-in-the-UI
branch
from
1c37cd5
to
d1d141b
Compare
Shadow243
reviewed
Oct 8, 2024
modules/nux/modules.php
Outdated
| @@ -80,6 +81,9 @@ public function process() { | |||
| if (data_source_available($modules, 'smtp')) { | |||
| $smtp_servers = count(Hm_SMTP_List::dump(false)); | |||
| } | |||
| if (data_source_available($modules, 'jmap')) { | |||
| $jmap_servers = count(Hm_IMAP_List::dump(false)); | |||
There was a problem hiding this comment.
Here you will get imap servers too, i mean it will combine imap ad jmap. If soo then we don't need to add an other link for jmap.
There was a problem hiding this comment.
With the first idea it was already well started, it was rather necessary to apply the filter here: https:/cypht-org/cypht/blob/master/modules/nux/modules.php#L64 without forgetting in this case to do it for this too: https:/cypht-org/cypht/blob/master/modules/nux/modules.php#L75
…P (RFC8621) by default.
Bienvenumoringa
force-pushed
the
promote-jmap-in-the-UI
branch
from
d1d141b
to
540324e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related task
Modify the text in the help section to explain that Cypht supports the JMAP (RFC8621) protocol in addition to IMAP and SMTP, and make JMAP available by default in standalone Cypht installations or those integrated with Tiki.