Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(compartments): avoid lowercase compartment strings #421

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

d33bs
Copy link
Member

@d33bs d33bs commented Jun 18, 2024

Description

This PR addresses #412 by updating convert_compartment_format_to_list to avoid lowercasing compartment name strings. As part of this work I had to update existing tests to allow them to pass. While I was updating materials I also added type hints to the function definition.

I believe new test warnings are emitted because of these changes.

Please don't hesitate to let me know if you have any questions. Thanks for any feedback!

Closes #412

What is the nature of your change?

  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • This change requires a documentation update.

Checklist

Please ensure that all boxes are checked before indicating that a pull request is ready for review.

  • I have read the CONTRIBUTING.md guidelines.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have deleted all non-relevant text in this pull request template.

Copy link
Member

@kenibrewer kenibrewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Excited to see changes that move us towards supporting new feature sets.

@d33bs
Copy link
Member Author

d33bs commented Jun 20, 2024

Thanks @kenibrewer ! Merging this in.

@d33bs d33bs merged commit 5aa2c28 into cytomining:main Jun 20, 2024
11 checks passed
@d33bs d33bs deleted the compartment-string-handling branch June 20, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants