bug(compartments): avoid lowercase compartment strings #421
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses #412 by updating
convert_compartment_format_to_list
to avoid lowercasing compartment name strings. As part of this work I had to update existing tests to allow them to pass. While I was updating materials I also added type hints to the function definition.I believe new test warnings are emitted because of these changes.
Please don't hesitate to let me know if you have any questions. Thanks for any feedback!
Closes #412
What is the nature of your change?
Checklist
Please ensure that all boxes are checked before indicating that a pull request is ready for review.