Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes with entrypoint to get working with GCP #36

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

jnsproul
Copy link
Contributor

@jnsproul jnsproul commented Oct 7, 2024

No description provided.

Copy link
Contributor

@cbcunc cbcunc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take a look at the one liner change requested for docker-compose.yml. I am also going to refrain from approving this PR until after the meeting tomorrow anyway because I want Mauriel to see it also.

@@ -1,7 +1,6 @@
version: '3.8'
version: "3.8"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version is a deprecated docker compose keyword now. It can and should be removed.

Copy link
Member

@Maurier Maurier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I had a look at this PR and I think these environment variable mappings are correct.

@cbcunc
Copy link
Contributor

cbcunc commented Oct 8, 2024

Meeting moved to bi-weekly. So this will be approved with the one-liner change is in place. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants